Apple will sell several million this weekend alone. My contract ends in March, so I will wait until then.
And, even then, I'm not sure that I will upgrade. My X is already more than I need, but there is a voice in the back of my head telling me to jump on Apple's annual upgrade program. My daughter uses it and it's pretty reasonable, considering she always has a new phone. I love the look of that green 11 Pro, but I love the price of the 11, which is basically the phone I am currently carrying, but with a slightly different screen, a different 2nd camera, and a much cheaper price.